Clean up Triforce Hunt U16's and GBK #3355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
approved these changes
Nov 12, 2023
Archez
approved these changes
Nov 18, 2023
briaguya-ai
reviewed
Nov 19, 2023
A-Green-Spoon
pushed a commit
to A-Green-Spoon/Shipwright
that referenced
this pull request
Nov 30, 2023
* Clean up Triforce Hunt U16's and GBK * Apply suggestions from code review
jamieklassen
pushed a commit
to jamieklassen/Shipwright
that referenced
this pull request
Mar 10, 2024
* Clean up Triforce Hunt U16's and GBK * Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a lot of references to gSaveContext.triforcePiecesCollected as U16's while it's a U8. The one in the save editor specifically screwed up the entry after this one in the gSaveContext because of it. So this PR cleans them all up and correctly references it as a U8 everywhere.
Also made the Ganon's Boss Key granting a lot cleaner. It now uses a RandomizerInf flag instead of constantly checking someone's current/required Triforce Pieces. As a result, this can also directly be utilized by the other Ganon's Boss Key checks in the future (and be removed from the LACS check).
Build Artifacts