Skip to content

Add LLR entrance from silo to the better debug warp screen #3424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

Sarge-117
Copy link
Contributor

@Sarge-117 Sarge-117 commented Nov 21, 2023

I couldn't see any obvious reason for this one not to be in the list (just went unnoticed, I'm guessing).

To be clear, this is the entrance to Lon Lon Ranch from the silo at the back.

Build Artifacts

@Pepe20129
Copy link
Contributor

Other parts of the code call the silo the "back tower", I think it'd be best to rename everything to silo or to rename this addition to back tower for consistency

@Sarge-117
Copy link
Contributor Author

It looks like English is the outlier (other languages refer to it as a silo a couple lines down), so I guess I'd lean towards that if there are no objections?

@Malkierian
Copy link
Contributor

I think the other languages should be changed, as it really is a tower, not a silo. That tower isn't storing grains, and it's not cylindrical. However, changing the other languages would probably be outside of the purview of this PR, as would changing "Back Tower" to "Tower", as I think it should be. I'd say just stick with "Back Tower" for now.

@Sarge-117
Copy link
Contributor Author

I think the other languages should be changed, as it really is a tower, not a silo. That tower isn't storing grains, and it's not cylindrical. However, changing the other languages would probably be outside of the purview of this PR, as would changing "Back Tower" to "Tower", as I think it should be. I'd say just stick with "Back Tower" for now.

Done!

And I'd agree - whether or not the building meets the definition of "silo" is for another time!

@Archez Archez merged commit bedb0a1 into HarbourMasters:develop Dec 29, 2023
@Sarge-117 Sarge-117 deleted the add-silo-entrance branch December 29, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants