Skip to content

Race Integrity QoL #3445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2023
Merged

Race Integrity QoL #3445

merged 2 commits into from
Nov 29, 2023

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Nov 25, 2023 •
edited by github-actions bot
Loading

  • All settings wrapped in a few ImGui::Disable calls based on a hidden cvar gDisableChangingSettings
  • Added ability to prevent spoiler file generation via gRandomizerDontGenerateSpoiler
    • When this is enabled, an additional string is appended for seed generation to prevent the same seed from being generated without this option on.
  • Support for dropping a shipofharkinian.json shaped file into the window, dropping it will:
    • Clear CVars
    • Apply CVars from dropped file
    • Close all unsafe windows (save editor, console, etc)
    • Clear all bindings in console
    • Print the SHA256 of the dropped file to the screen

I figure for a race the participants will be required to on stream/recording show the version of Ship of they are running, as well dragging the file in (which will print the expected SHA256 to the screen)

Build Artifacts

Archez
Archez reviewed Nov 25, 2023
View reviewed changes
briaguya-ai
briaguya-ai reviewed Nov 25, 2023
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple questions about the file drop implementation but overall this makes sense

@garrettjoecox garrettjoecox force-pushed the race-integrity branch 3 times, most recently from 59ec0ce to 1db6a22 Compare November 25, 2023 22:07
@briaguya-ai
Copy link
Contributor

looks like this needs some #include <algorithm>s

@garrettjoecox garrettjoecox force-pushed the race-integrity branch 2 times, most recently from f77f6b2 to 9bd3bd2 Compare November 26, 2023 17:12
@garrettjoecox
Copy link
Contributor Author

garrettjoecox commented Nov 26, 2023 •
edited
Loading

Made a few adjustments:

  • Added gRandomizerDontGenerateSpoiler, does what it says.
  • Added some missing cvars to the reset cvars lists.
  • Added a try/catch around the randomizer spoiler file parse to prevent crash on invalid file drop.

@garrettjoecox garrettjoecox force-pushed the race-integrity branch 2 times, most recently from b709f61 to 6ff2820 Compare November 26, 2023 18:52
@briaguya-ai briaguya-ai merged commit fdcd9a7 into HarbourMasters:develop-macready Nov 29, 2023
A-Green-Spoon pushed a commit to A-Green-Spoon/Shipwright that referenced this pull request Nov 30, 2023
@garrettjoecox @A-Green-Spoon
Race Integrity QoL (HarbourMasters#3445)
b9eeb2b 
* Add gDisableChangingSettings

* Add support for dropping a config file to overwrite CVars
@garrettjoecox garrettjoecox mentioned this pull request Dec 11, 2023
Merged
@garrettjoecox garrettjoecox deleted the race-integrity branch March 4, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archez Archez Archez approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrettjoecox @briaguya-ai @Archez