Skip to content

Only emit changed flags #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 28, 2023
Merged

Only emit changed flags #3489

merged 1 commit into from
Dec 28, 2023

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Dec 5, 2023 •
edited by github-actions bot
Loading

QOL for both anchor and logs, some actors would set or unset flags every frame regardless of their state which caused lots of unnecessary logs and hook emits.

Build Artifacts

@garrettjoecox garrettjoecox force-pushed the only-emit-changed-flags branch 2 times, most recently from a835edc to 913b188 Compare December 5, 2023 02:28
Archez
Archez approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice optimization 👍

I added a minor name change suggestion, but non-blocking for merge.

@garrettjoecox garrettjoecox force-pushed the only-emit-changed-flags branch from 913b188 to e7227cc Compare December 26, 2023 21:38
@garrettjoecox garrettjoecox merged commit f6a6b88 into HarbourMasters:develop Dec 28, 2023
@garrettjoecox garrettjoecox deleted the only-emit-changed-flags branch March 4, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Archez Archez Archez approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garrettjoecox @Archez @briaguya-ai