Skip to content

Fixes some Spoiler Parsing Bugs #3759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 30, 2023
Merged

Fixes some Spoiler Parsing Bugs #3759

merged 4 commits into from
Dec 30, 2023

Conversation

leggettc18
Copy link
Contributor

@leggettc18 leggettc18 commented Dec 29, 2023 •
edited by github-actions bot
Loading

Fixes the following issues with parsing spoiler files.

  • Enabled Tricks were not being parsed correctly. The way it was being parsed was expecting a number, but we were outputting names. I had to update mTrickOptions in Settings to store the correct names and put those in a lookup table on boot.
  • Excluded Locations were not being parsed correctly on boot, because the spoiler was being parsed before the StaticData tables had been initialized.
  • Bombchu Drops setting was not being parsed correctly.
  • Dropped spoiler files weren't being parsed at all, because it was grabbing the file location before updating gSpoilerLog with the new file. Oops.
  • Excluded Locations and Enabled Tricks previously parsed from a spoiler were getting overwritten by the CVars. This fixes that by not pulling the options from CVars when a spoiler has been loaded.

Build Artifacts

@leggettc18 leggettc18 merged commit dbb1e60 into HarbourMasters:develop-rando Dec 30, 2023
@leggettc18 leggettc18 deleted the spoiler-parse-fixes branch December 30, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@leggettc18