[Tweak] Move Personal Notes to Save File #3909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspectredc
approved these changes
Feb 9, 2024
|
The null push was carried over from what it was before. I didn't add that, it's just necessary to prevent crashes with an empty vector for loading/display. There's probably a more elegant way to do it, that just wasn't my focus for this, so I didn't look. |
briaguya-ai
approved these changes
Feb 11, 2024
Archez
reviewed
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the personal notes save in the save file under a new "itemTracker" section. This fixes rare issues with notes bleeding through saves (since CVarSet doesn't save blank strings), as well as the problem of notes not being copied to new save slots when a save is copied in-game.
Build Artifacts