Fix: Actor init flow with object loading #3987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hopefully this hasn't caused you much issues in the VB branch @garrettjoecox 🙂 |
garrettjoecox
approved these changes
Feb 29, 2024
71f8766 to
d68bf1a
Compare
|
Rebased to macready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding back the object loaded detection for actors, there is now a second actor init path when the actor's object hasn't loaded during the first init check. This second init location was missing our custom logic for hooks and the enemy health bar handling.
Targeting develop, but if we think we may push out a new macready in the future, we'd probably just want to cherry pick this.
Build Artifacts