Fixes crashes on asan related to audio. #4049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
reviewed
Apr 11, 2024
briaguya-ai
approved these changes
Apr 20, 2024
|
actually should this go to macready? edit: i went ahead and rebased it onto macready |
Found in MM
Malkierian
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in MM
The issue is actually in the caller function, and it's believed to exist on the original game. Basically the caller doesn't correctly stop loading the sample using
aLoadBuffercorrectly. It tries to copy a set number of frames, but the issue is that the samples don't always have that much data.The mixer func shouldn't be modified imo
The exporter should generate padded samples that have enough data to account for alignment.
Modifying just the mixer is more brittle because there may be other code affected by alignment issues.
The calling func is just not calculating sample positions correctly, and the samples aren't aligned.
Build Artifacts