Fix some memory leaks with WrappedText and LoadArrayByNameAsVec3s #4144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briaguya-ai
approved these changes
May 9, 2024
garrettjoecox
approved these changes
May 10, 2024
3f67fed
into
HarbourMasters:develop-macready
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WrappedText for UIWidgets was using strdup with having the return string freed up later. Rather than using strdup, we can just return std::string and have the caller execute
.c_str()on the result and avoid malloc/free issues all together. (see #4043)Also address a memory leak from LoadArrayByNameAsVec3s which mallocs a new array every call to it on the static pause link drawing. The Vec3s resource copies by value to the skelanime joint table, but the original Vec3s resource was not being freed after.
Build Artifacts