Fix oversight causing big poes check not to run #5303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malkierian
approved these changes
Apr 3, 2025
leggettc18
approved these changes
Apr 3, 2025
|
I'm not super clear on #5297 to know if this fixes that, but this seems like a correct change regardless. |
|
OK, found that Default + Interior Simple failed before this PR and succeeds after it, so I think I can safely assume this does fix #5297 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an oversight with where the new big poes check was placed, causing it to not run when other entrance randos were not on.
This also fixes an oversight where the overworld key was not being added when interior shuffle was set to simple.
should fix #5297
Build Artifacts