Mixed pools now properly disables itself when hidden. #5341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
approved these changes
Apr 6, 2025
Archez
approved these changes
Apr 7, 2025
Malkierian
approved these changes
Apr 8, 2025
Varuuna
pushed a commit
to Varuuna/Shipwright
that referenced
this pull request
Apr 12, 2025
…#5341) * mixed pools now sets itself off when hidden * the clanging never ends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5331
Previously mixed pools settings were on in the background if enabled and then hidden, even if they did nothing, causing issues when other features checked it. Now they are properly unset in settings finalization. Additionally, mixed pools now only appears when 2 different pools are enabled, as it does nothing with only 1.
Build Artifacts