Fix Rando Give for Adult Fishing as Child Glitch #5349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leggettc18
approved these changes
Apr 8, 2025
Archez
requested changes
Apr 8, 2025
Co-authored-by: Archez <[email protected]>
Archez
reviewed
Apr 8, 2025
Co-authored-by: Archez <[email protected]>
Malkierian
approved these changes
Apr 8, 2025
Archez
approved these changes
Apr 8, 2025
Varuuna
pushed a commit
to Varuuna/Shipwright
that referenced
this pull request
Apr 12, 2025
* VBVBVB * Update soh/soh/Enhancements/randomizer/hook_handlers.cpp * Update soh/soh/Enhancements/randomizer/hook_handlers.cpp * first try
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5345
Adds a VB block to handle the gold scale as child glitch in rando. Note that thanks to the way the VBs are currently setup, the child fishing reward can't be locked out - it will always be given first.
Long version because this file is huge:
Current flow:
-After child reward complete, catching a larger fish and performing the glitch hits the VB_GIVE_RANDO_FISHING_PRIZE block in Case 11, and gets sent to Case 23, as Link is child and has already received the child reward
-If performed correctly, it hits the else block in Case 23, giving the Gold Scale - new VB interrupts this flow
Build Artifacts