Add temporary patch for invisible boulder fragments #5352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Malkierian
approved these changes
Apr 8, 2025
leggettc18
approved these changes
Apr 8, 2025
Varuuna
pushed a commit
to Varuuna/Shipwright
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons not understood, the change made in LUS by Kenix3/libultraship#721 was causing boulder fragments to display invisible.
As a temporary solution, this adds a gfx patch to replace the render mode and color combiner with the values used by the effect spawner/manager in
EffectSsKakera_Draw. This works enough to get the fragments to display like they did before from what I can tell.Ideally it would be great to investigate the LUS change itself and see if what it was trying to solve for is correctly accounted for.
Build Artifacts