Fix Docked Tracker Ghosting #5354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t registers as docked to fix the framebuffer ghosting.
Archez
reviewed
Apr 8, 2025
Archez
approved these changes
Apr 8, 2025
Varuuna
pushed a commit
to Varuuna/Shipwright
that referenced
this pull request
Apr 12, 2025
* Dynamically changes a tracker's chosen color's opacity to full when it registers as docked to fix the framebuffer ghosting. * remove debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by a transparent color being applied to the window even while it was docked. This sets it up to dynamically change a tracker's chosen color's opacity to full when it registers as docked to fix it.
Underlying cause: it seems like ImGui itself is supposed to do that automatically when a window is docked (could make the ghosting go away without this by docking another window in the same tab group, like the check tracker, which would then make the ImGuiWindow::DockIsActive be true when it was false on its own), but no need waiting on the process of repro and investigation and subsequent release over there.
Build Artifacts