Skip to content

Fix Fishing-related checks location pool (again) #5378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leggettc18
Copy link
Contributor

@leggettc18 leggettc18 commented Apr 10, 2025

I missed the fact that Hyrule Loach Check is, in fact, not of type RC_FISH but of type RC_STANDARD. Oops. I tested all the settings to confirm that nothing ended up in the spoiler log that shouldn't have been there. I would encourage someone else to do the same.

Build Artifacts

@leggettc18 leggettc18 added this to the 9.0.2 milestone Apr 10, 2025
@leggettc18
Copy link
Contributor Author

Had Spoon re-gen the Hint Weekly he originally genned on 9.0.0, it was an exact match, so confirmed this fixes the bug I introduced into 9.0.1.

Copy link
Contributor

@Malkierian Malkierian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything glaringly wrong, if it fixes the bug but keeps the previously desired solution, then :shipit:

@leggettc18 leggettc18 merged commit 05e96f3 into HarbourMasters:develop-blair Apr 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants