Fix weird egg logic

[Malkierian]

There were three problems with weird egg logic. First, RAND_INF_WEIRD_EGG was getting set when talking to Malon, even if weird egg was shuffled (availability change). This would falsely show things past Talon as accessible after talking to Malon but without the egg. Second was that RAND_INF_WEIRD_EGG wasn't getting set if the egg was collected elsewhere due to shuffling it. These were both solved by removing the eventchkinf trigger for it from RandomizerOnFlagSetHandler() and moving it to the trade item give processing in z_parameter instead.

The third was that logic was showing "Song from Impa" as accessible before getting the egg when it wasn't shuffled because the entrance access was checking for the RSK not being set, which was redundant because of ApplyItemEffect() still being triggered when the egg was vanilla, so CanUse(RG_WEIRD_EGG) there covers both cases, so this removes that RSK check.

Build Artifacts

• soh-mac.zip
• soh-linux.zip
• soh-windows.zip

[Pepe20129]

Is RAND_INF_WEIRD_EGG the flag for the item? I thought it was the one for the check

[Malkierian]

No, the check still uses EVENTCHKINF_OBTAINED_POCKET_EGG for whatever's on Malon. Pretty sure that flag is misnamed.

[leggettc18]

I'll maintain my approval of this PR because I think this is a pre-existing issue, but I have noticed during testing this that if you shuffle the weird egg and use it to move Talon, you lose access to the HC Malon Egg check. Now I did use Save Editor to hack in the Cucco so if that does something weird that isn't possible in normal gameplay please do let me know. I don't think we necessarily need to fix that here though. Might require either source intrusions or new VB Hooks to make it work properly.

[leggettc18]

As far as seed-gen logic goes everything here works great though.

[leggettc18]

I'll merge this for now, the Malon behavior isn't caused by this anyway and fixing it should be the job of a different PR.