Fix boss key kaleido text for NTSC

[Archez]

The texture name for the boss key item name text in kaleido is named gBigKeyItemNameENGTex in the NTSC versions, but named gUnusedBigKeyItemNameENGTex in the PAL versions. The code is using gUnusedBigKeyItemNameENGTex to for rendering, causing NTSC to crash when hovering over the boss key.

I think gBigKeyItemNameENGTex would be the better name overall, but for a develop-blair bugfix, I'd rather have the NTSC OTRs require regen instead of the PAL ones. We can always rename and change the code later for a 9.1.0 release in the future.

Build Artifacts

• soh-mac.zip
• soh-windows.zip
• soh-linux.zip

[leggettc18]

So the texture for the BigKeyItemNameTex doesn't visibly appear anywhere but the game tries to load it anyway? Am I understanding that right?

[Archez]

The game was crashing, as it tries to load the resource by that name, but it didn't exist

[leggettc18]

OK, since this one is fixing a crash should we make it actually require an OTR regen? Or is there not a way to do that for only the NTSC versions?

[Archez]

There is not a way currently to selectively do a regen. We can just call it out again in the changelog.
The crash would only occur for anyone that strictly had NTCS versions. If someone had a combo of PAL and NTSC for mq non-mq, then it wouldn't crash).

[leggettc18]

Alright, figured I'd ask. Would be nice if we could trigger rebuilds for only NTSC, but at this point by the time we could implement it we probably wouldn't need it anymore.

[leggettc18]

Confirmed I could repeat the crash pre-regen and no crash post-regen. Merging now.