Skip to content

Fix misspelling of Broken Giant's Knife fix CVar #5395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JordanLongstaff
Copy link
Contributor

@JordanLongstaff JordanLongstaff commented Apr 12, 2025

The CVar and corresponding fix are broken until this merges.

Build Artifacts

@leggettc18
Copy link
Contributor

This should probably be targeted at develop-blair so it gets into 9.0.2

@JordanLongstaff JordanLongstaff changed the base branch from develop to develop-blair April 12, 2025 14:10
@JordanLongstaff
Copy link
Contributor Author

Should I do that with all my PRs?

@leggettc18
Copy link
Contributor

Not necessarily. This is a bugfix, so we'd want it in Blair. The colored in name of the currently playing sequence is more of a feature so it could've stayed on develop.

@leggettc18 leggettc18 merged commit 46b40b0 into HarbourMasters:develop-blair Apr 12, 2025
6 checks passed
@JordanLongstaff JordanLongstaff deleted the fix-bgs-spelling branch April 12, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants