Fix Entrance Rando weather override behavior #5403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leggettc18
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with how entrance rando hooks where overriding the weather/skybox behavior. The problem was that
Play_InitEnvironmentwas being executed twice (the second time with the updated weather/environment content applied), which resulted inEnvironment_Initinserting additional lights. This meant there was always double the lights added, potentially overriding/de-linking previous lights, which lead to strange behavior like characters having the wrong lighting.This bug was introduced by moving the entrance rando methods out of the game src into hooks with 9.0.0. A new hook has been added for
AfterSceneCommandswhich executes right after all the commands are processed, allowing any overrides to happen as soon as possible. In this case, it allows executingEntrance_OverrideWeatherStatebeforePlay_InitEnvironment, which is how 8.0.6 effectively was.Build Artifacts