Skip to content

Compound top level module name #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dfithian
Copy link
Contributor

@dfithian dfithian commented Nov 2, 2024

Support compound top-level module names like Foo.Bar.Baz.

@joel-bach

@joel-bach
Copy link
Member

Hey @dfithian

Thank you very much for the pull request, it is much appreciated!

It looks good from my POV, the only thing I'd like to ask is that you add some kind of test so we can ensure this works as intended or at least does not break compilation. The easiest way to do this would probably be to add a system test on level 1 (here:

(generateCode { fileName = "spot_api.yml"; extraFlags = [ "--opaque-schema=\"aggTrade\"" ]; })
) where you can pass in a flag with a new module name e.g. for the z_complex_self_made_example.yml specification. Let me know if you have questions.

@dfithian
Copy link
Contributor Author

dfithian commented Nov 9, 2024

Sweet, done!

@joel-bach joel-bach merged commit db004b9 into Haskell-OpenAPI-Code-Generator:master Nov 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants