Fix texture edge with transparent objects #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "texture edge" mode as it is written in the shader assumes non-transparent objects, or actually that the alpha mask goes around a non-transparent object. Texture edge + transparent objects can be represented with the threshold solution instead. The transparent balloons in Mario Kart 64 use CVG_X_ALPHA with blender turned on (new colour * alpha + previous colour * (1-alpha)).
This was referenced Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "texture edge" mode as it is written in the shader assumes non-transparent objects, or actually that the alpha mask goes around a non-transparent object. Texture edge + transparent objects can be represented with the threshold solution instead.
The transparent balloons in Mario Kart 64 use CVG_X_ALPHA with blender turned on (new colour * alpha + previous colour * (1-alpha)).