AELEMFASTLEX_STORE - support negative keys, skip unnecessary check #20331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3ed123a to
2fe9ddb
Compare
This commit: * Adds support for negative keys, as per the original AELEMFAST_LEX * Changes an if() check for a "useless assignment to a temporary" into an assert, since this condition should never be true when the LHS is the result of an array fetch.
2fe9ddb to
b59c3c1
Compare
Contributor
Author
|
Unless anyone has objections, I'd like to merge this before the next dev release in just over a week's time. |
Contributor
Author
|
These two changes were suggested by and discussed with @iabyn. No-one else has commented in a month, so I'm merging them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit:
AELEMFAST_LEXif()check for a "useless assignment to a temporary"into an assert, since this condition should never be true when the
LHS is the result of an array fetch.
Both changes address feedback from @iabyn in #20063.