Skip to content

Commit c0d3cb3

Browse files
committed
ignoredHighlightLanguages now works for supported langs
Resolves #2956
1 parent c38985f commit c0d3cb3

File tree

3 files changed

+23
-19
lines changed

3 files changed

+23
-19
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ title: Changelog
77
### Bug Fixes
88

99
- References to type aliases defined as mapped types will now correctly create a reference to the type alias, #2954.
10+
- `ignoredHighlightLanguages` can now be used to prevent warnings for codeblocks containing languages
11+
which are supported by Shiki but are not loaded, #2956.
1012

1113
## v0.28.4 (2025-05-04)
1214

src/lib/output/themes/MarkedPlugin.tsx

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -88,21 +88,21 @@ export class MarkedPlugin extends ContextAwareRendererComponent {
8888
lang = lang || "typescript";
8989
lang = lang.toLowerCase();
9090
if (!isSupportedLanguage(lang)) {
91-
this.application.logger.warn(
92-
i18n.unsupported_highlight_language_0_not_highlighted_in_comment_for_1(
93-
lang,
94-
getFriendlyFullName(this.page?.model || { name: "(unknown)" }),
95-
),
96-
);
97-
return text;
98-
}
99-
if (!isLoadedLanguage(lang)) {
100-
this.application.logger.warn(
101-
i18n.unloaded_language_0_not_highlighted_in_comment_for_1(
102-
lang,
103-
getFriendlyFullName(this.page?.model || { name: "(unknown)" }),
104-
),
105-
);
91+
if (isLoadedLanguage(lang)) {
92+
this.application.logger.warn(
93+
i18n.unloaded_language_0_not_highlighted_in_comment_for_1(
94+
lang,
95+
getFriendlyFullName(this.page?.model || { name: "(unknown)" }),
96+
),
97+
);
98+
} else {
99+
this.application.logger.warn(
100+
i18n.unsupported_highlight_language_0_not_highlighted_in_comment_for_1(
101+
lang,
102+
getFriendlyFullName(this.page?.model || { name: "(unknown)" }),
103+
),
104+
);
105+
}
106106
return text;
107107
}
108108

src/lib/utils/highlighter.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -162,8 +162,12 @@ export async function loadHighlighter(
162162
highlighter = new ShikiHighlighter(hl, lightTheme, darkTheme);
163163
}
164164

165+
function isPlainLanguage(lang: string) {
166+
return ignoredLanguages?.includes(lang) || plaintextLanguages.includes(lang);
167+
}
168+
165169
export function isSupportedLanguage(lang: string) {
166-
return ignoredLanguages?.includes(lang) || getSupportedLanguages().includes(lang);
170+
return isPlainLanguage(lang) || supportedLanguages.includes(lang);
167171
}
168172

169173
export function getSupportedLanguages(): string[] {
@@ -175,9 +179,7 @@ export function getSupportedThemes(): string[] {
175179
}
176180

177181
export function isLoadedLanguage(lang: string): boolean {
178-
return (
179-
isSupportedLanguage(lang) || highlighter?.supports(lang) || false
180-
);
182+
return isPlainLanguage(lang) || highlighter?.supports(lang) || false;
181183
}
182184

183185
export function highlight(code: string, lang: string): string {

0 commit comments

Comments
 (0)