Improve delete-only-untagged-versions flag and minor bug fix
#97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delete-only-untagged-versions flag behaviour consistent with delete-only-pre-release-versions flagdelete-only-untagged-versions flag and minor bug fix
nishthaGupta
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With release v4.0.0, we introduced
delete-only-untagged-versionsto delete only untagged container versions. This is somewhat equivalent to deleting prerelease versions for other package types.num-old-versions-to-deletealong withdelete-only-pre-release-versionsdelete-only-pre-release-versionsis true, we defaultmin-versions-to-keepto 0.delete-only-untagged-versionsdoes not behave in the same way. This is unnecessary inconsistency between two kind of similar flags and this PR aims to fix that.This also includes a minor bug fix where if two versions have same created_at timestamp (rare), then either could get deleted. Added a logic to sort by ID if created_at timestamp matches