Set max memory of SortBasedPusher based off Spark configs #3203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboFei
reviewed
Apr 8, 2025
| // set max task memory conf based on Spark conf | ||
| if (celebornConf.clientPushSortMaxMemoryBytes() <= 0L) { | ||
| double memoryStorageFraction = | ||
| sparkConf.getDouble(package$.MODULE$.MEMORY_FRACTION().key(), 0.6); |
There was a problem hiding this comment.
For spark-2.4 UT
Error: /home/runner/work/celeborn/celeborn/client-spark/common/src/main/java/org/apache/spark/shuffle/celeborn/SortBasedPusher.java:553:48: error: cannot find symbol
There was a problem hiding this comment.
Maybe you can use the string value directly?
There was a problem hiding this comment.
Can we get the values of maxOffHeapMemory/maxHeapMemory from the MemoryManager through reflection?
There was a problem hiding this comment.
Thank you for the feedback, I will try using reflection and re-submit.
|
This PR is stale because it has been open 20 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This issue was closed because it has been staled for 10 days with no activity. |
|
gentle ping @helenweng-stripe Any update? |
5590ef0 to
0dffcf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Set the max memory threshold to actual memory allocated to the task. This is reverse-calculated from how Spark determines it since TaskMemoryManager in Spark does not expose how much memory is available to a task.
Calculation is based on whether mode is onheap or offheap:
spark.memory.offHeap.sizeorspark.executor.memory) - reservedMemory (hardcoded to )) *spark.memory.fraction*celeborn.client.spark.push.sort.memory.maxMemoryFactor/spark.executor.coresBased on calculations here: https://github.com/apache/spark/blob/branch-3.3/core/src/main/scala/org/apache/spark/memory/UnifiedMemoryManager.scala#L213-L235
MaxMemory can be set statically with new setting
celeborn.client.spark.push.sort.memory.maxMemoryBytes. It is only dynamically calculated withceleborn.client.spark.push.sort.memory.calculateMaxMemoryBytesset to true (default false).Better solution would probably be to expose
getMaxMemoryon the spark side, however it is currently not available.Why are the changes needed?
Currently maxMemory is set to
Runtime.getRuntime().maxMemory() * maxMemoryFactorwhereRuntime.getRuntime().maxMemory()equals the amount of memory available to the entire app. Thus for some large tasks, SortBasedPusher withceleborn.client.spark.push.sort.memory.useAdaptiveThresholdenabled will always OOM.Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit tests
We also are running with this in prod.