Skip to content

ci: fix dl failed #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 15, 2025
Merged

ci: fix dl failed #983

merged 13 commits into from
Jun 15, 2025

Conversation

zhongjiajie
Copy link
Member

@zhongjiajie zhongjiajie commented Jun 14, 2025

do not know the root cause, but https://mp.weixin.qq.com will raise an error in our pipeline, so maybe we should directly ignore them, because

  • if the link work, everything works fine and does not need to change
  • if the link do not work, which mean article is delete and can not revert in wechat
2025-06-14T01:14:07.0668795Z /usr/local/lib/node_modules/markdown-link-check/node_modules/async/dist/async.js:325
2025-06-14T01:14:07.0669750Z             if (fn === null) throw new Error("Callback was already called.");
2025-06-14T01:14:07.0670643Z                              ^
2025-06-14T01:14:07.0670896Z 
2025-06-14T01:14:07.0671053Z Error: Callback was already called.
2025-06-14T01:14:07.0672111Z     at /usr/local/lib/node_modules/markdown-link-check/node_modules/async/dist/async.js:325:36
2025-06-14T01:14:07.0673145Z     at /usr/local/lib/node_modules/markdown-link-check/node_modules/async/dist/async.js:249:17
2025-06-14T01:14:07.0674040Z     at /usr/local/lib/node_modules/markdown-link-check/index.js:212:13
2025-06-14T01:14:07.0675247Z     at /usr/local/lib/node_modules/markdown-link-check/node_modules/link-check/lib/proto/http.js:119:21
2025-06-14T01:14:07.0676395Z     at done (/usr/local/lib/node_modules/markdown-link-check/node_modules/needle/lib/needle.js:474:14)
2025-06-14T01:14:07.0677831Z     at PassThrough.<anonymous> (/usr/local/lib/node_modules/markdown-link-check/node_modules/needle/lib/needle.js:734:9)
2025-06-14T01:14:07.0678801Z     at PassThrough.emit (node:events:536:35)
2025-06-14T01:14:07.0679383Z     at endReadableNT (node:internal/streams/readable:1698:12)
2025-06-14T01:14:07.0680201Z     at process.processTicksAndRejections (node:internal/process/task_queues:82:21)

@zhongjiajie
Copy link
Member Author

I have tested and found out the check will fail when more than two links start with https://mp.weixin.qq.com in a single article

@zhongjiajie zhongjiajie requested a review from SbloodyS June 15, 2025 14:56
@zhongjiajie zhongjiajie merged commit 39232a5 into master Jun 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants