HDDS-3316. Checkstyle check fails silently in case of mvn related errors

[elek]

What changes were proposed in this pull request?

rom the last master build:

https://github.com/apache/hadoop-ozone/runs/550746880?check_suite_focus=true

Checkstyle is failed due to a maven error:

[ERROR] Failed to execute goal on project hadoop-hdds-common: Could not resolve dependencies for project org.apache.hadoop:hadoop-hdds-common:jar:0.6.0-SNAPSHOT: Could not find artifact org.apache.hadoop:hadoop-hdds-config:jar:0.6.0-SNAPSHOT in apache.snapshots.https (https://repository.apache.org/content/repositories/snapshots) -> [Help 1]
[ERROR] Failed to execute goal on project hadoop-hdds-client: Could not resolve dependencies for project org.apache.hadoop:hadoop-hdds-client:jar:0.6.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.hadoop:hadoop-hdds-common:jar:0.6.0-SNAPSHOT, org.apache.hadoop:hadoop-hdds-config:jar:0.6.0-SNAPSHOT: Could not find artifact org.apache.hadoop:hadoop-hdds-common:jar:0.6.0-SNAPSHOT in apache.snapshots.https (https://repository.apache.org/content/repositories/snapshots) -> [Help 1]

But it remained green.

We should fail the check if the maven run couldn't succeed.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-3316

Please replace this section with the link to the Apache JIRA)

How was this patch tested?

hadoop-ozone/dev-support/checks/checkstyle.sh
echo $?

1. Create a syntax error in your pom.xml (expected: exit code 1, without the patch: 0)
2. Create a checkstyle error (expected: exit code 1)
3. Fix the checkstyle error (expected: exit code 0)

[adoroszlai]

Thanks @elek for finding and fixing this problem. Please note that an unrelated commit is present in the PR.

[elek]

Thanks the review @adoroszlai. Merged it to master.