HDDS-3411. Switch Recon SQL DB to Derby. #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swagle
reviewed
Apr 17, 2020
hadoop-ozone/recon-codegen/src/main/java/org/hadoop/ozone/recon/codegen/ReconSqlDbConfig.java
Show resolved
Hide resolved
swagle
reviewed
Apr 17, 2020
hadoop-ozone/recon-codegen/src/main/java/org/hadoop/ozone/recon/codegen/JooqCodeGenerator.java
Show resolved
Hide resolved
swagle
reviewed
Apr 17, 2020
hadoop-ozone/recon-codegen/src/main/java/org/hadoop/ozone/recon/codegen/JooqCodeGenerator.java
Show resolved
Hide resolved
swagle
reviewed
Apr 17, 2020
...recon/src/main/java/org/apache/hadoop/ozone/recon/persistence/DefaultDataSourceProvider.java
Show resolved
Hide resolved
|
@avijayanhwx Thanks for working on this! Looks like the integration test failure might be related to this change. |
...on/src/test/java/org/apache/hadoop/ozone/recon/persistence/TestReconWithDifferentSqlDBs.java
Show resolved
Hide resolved
hadoop-ozone/recon-codegen/src/main/java/org/hadoop/ozone/recon/codegen/JooqCodeGenerator.java
Show resolved
Hide resolved
elek
reviewed
Apr 17, 2020
added 2 commits
April 22, 2020 17:53
vivekratnavel
approved these changes
Apr 23, 2020
...one/recon-codegen/src/main/java/org/hadoop/ozone/recon/schema/ReconTaskSchemaDefinition.java
Outdated
Show resolved
Hide resolved
...e/recon-codegen/src/main/java/org/hadoop/ozone/recon/schema/UtilizationSchemaDefinition.java
Outdated
Show resolved
Hide resolved
|
@avijayanhwx Thanks for working on this! |
This was referenced Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Recon currently uses Sqlite as its defacto SQL DB with an option to configure other JDBC compatible databases. However, on some platforms like the IBM power pc, this causes problems from compile time since it does not have the sqlite native driver. This task aims to change the default SQL DB used by Recon to Derby, but retains the out of the box support (no need to supply the driver) for Sqlite as well.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3411
How was this patch tested?
Added unit tests.
Manually tested on docker with Derby and Sqlite.
Built the recon modules on IBM PPC host.