fix(doctrine): wrong return type without name converter #6079 (#6254)

soyuka · web-flow · commit 88d88ed2c41c · 2024-03-29T15:02:44.000+01:00
diff --git a/src/Doctrine/Odm/Filter/AbstractFilter.php b/src/Doctrine/Odm/Filter/AbstractFilter.php
@@ -86,7 +86,7 @@ protected function isPropertyEnabled(string $property, string $resourceClass): b
     protected function denormalizePropertyName(string|int $property): string
     {
         if (!$this->nameConverter instanceof NameConverterInterface) {
-            return $property;
+            return (string) $property;
         }
 
         return implode('.', array_map($this->nameConverter->denormalize(...), explode('.', (string) $property)));
diff --git a/src/Doctrine/Orm/Filter/AbstractFilter.php b/src/Doctrine/Orm/Filter/AbstractFilter.php
@@ -80,7 +80,7 @@ protected function isPropertyEnabled(string $property, string $resourceClass): b
     protected function denormalizePropertyName(string|int $property): string
     {
         if (!$this->nameConverter instanceof NameConverterInterface) {
-            return $property;
+            return (string) $property;
         }
 
         return implode('.', array_map($this->nameConverter->denormalize(...), explode('.', (string) $property)));

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ protected function isPropertyEnabled(string $property, string $resourceClass): b`
`86`	`86`	`protected function denormalizePropertyName(string\|int $property): string`
`87`	`87`	`{`
`88`	`88`	`if (!$this->nameConverter instanceof NameConverterInterface) {`
`89`		`- return $property;`
	`89`	`+ return (string) $property;`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`return implode('.', array_map($this->nameConverter->denormalize(...), explode('.', (string) $property)));`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ protected function isPropertyEnabled(string $property, string $resourceClass): b`
`80`	`80`	`protected function denormalizePropertyName(string\|int $property): string`
`81`	`81`	`{`
`82`	`82`	`if (!$this->nameConverter instanceof NameConverterInterface) {`
`83`		`- return $property;`
	`83`	`+ return (string) $property;`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`return implode('.', array_map($this->nameConverter->denormalize(...), explode('.', (string) $property)));`