fix: searchfilter with nested custom identifiers

[mrossard]

Q	A
Branch?	3.1
Tickets	Closes 5735

This undoes the revert of #5623 , but (as far as i can see) fixes the part that was causing #5735

[soyuka]

not good for performances, isn't there a way to prevent this exception?

[mrossard]

yep, that's not great for perfs but i can't see another way to check whether what i have is a valid IRI beforehand. That should not change much performance-wise though; I actually copied this logic from SearchFilterTrait::getIdFromValue, which was called before :

core/src/Doctrine/Common/Filter/SearchFilterTrait.php

Lines 121 to 132 in b58ec12

	protected function getIdFromValue(string $value): mixed
	{
	try {
	$iriConverter = $this->getIriConverter();
	$item = $iriConverter->getResourceFromIri($value, ['fetch_data' => false]);
	return $this->getPropertyAccessor()->getValue($item, 'id');
	} catch (InvalidArgumentException) {
	// Do nothing, return the raw value
	}
	return $value;

[mrossard]

I actually have another version that handle that case better, but i'll leave it for another PR since it needs quite a lot more to work.

[soyuka]

don't worry let's go for this I think it's just find and maybe we can do better when working on #2400 next year!

[soyuka]

could you rebase though? Thanks!

[mrossard]

could you rebase though? Thanks!

Done!

[soyuka]

perfect thanks and @dannyvw tried on his project so fingers crossed :p