-
-
Notifications
You must be signed in to change notification settings - Fork 765
fix: Correct spelling and semantic mistakes in method naming #1970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you please sign CLA? |
I should have now signed the CLA |
In order to not make this change breaking it would make sence to mark method names containing typos as |
The changes should reflect your suggestion now @mykola-mokhnach: Deprecated rather than remove methods containing typos. |
...in/java/io/appium/java_client/android/options/context/SupportsShowChromedriverLogOption.java
Outdated
Show resolved
Hide resolved
...in/java/io/appium/java_client/android/options/context/SupportsShowChromedriverLogOption.java
Outdated
Show resolved
Hide resolved
src/main/java/io/appium/java_client/ios/options/simulator/SupportsCustomSslCertOption.java
Show resolved
Hide resolved
...in/java/io/appium/java_client/ios/options/simulator/SupportsSimulatorTracePointerOption.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fishey2 would you mind fixing Checkstyle violations?
@valfirst happy to work around the Checkstyle issue, however the actual checkstyle issue is apparent because it thinks the deprecated method In this case there is only the two methods in the class and moving it up shouldn't affect anything else, but workaround the checkstyle issue. I will push this change now. |
…1967) - affects SupportsCustomSslCertOption, SupportsShowChromedriverLogOption and SupportsSimulatorTracePointerOption
Change list
SupportsCustomSslCertOption
methodsetCustomSSLCert()
is nowgetCustomSSLCert()
affectsXCUITestOptions
SupportsSimulatorTracePointerOption
methoddoesSimulatorTracePointerd()
is nowdoesSimulatorTracePointer()
affectsXCUITestOption
SupportsShowChromedriverLogOption
methodssetDhowChromedriverLog(boolean)
anddoesDhowChromedriverLog()
are nowsetShowChromedriverLog(boolean)
anddoesShowChromedriverLog()
respectively affectsExpressoOptions
andUIAutomator2Options
Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
x
in the boxes that applyDetails
No functional changes