Skip to content

chore: Perform listeners cleanup periodically #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

Listeners are cleaned up lazily, e.g. every time getListeners API
is called we also remove garbage-collected items. Although, due to an
unpredictable nature of the garbage collector and no guarantees about the
frequency of getListeners API calls we schedule the below loop to be executed every
minute, and make sure there are no extra references to obsolete listeners

Types of changes

  • No changes in production code.
  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach mykola-mokhnach merged commit 2bd4480 into appium:master Nov 17, 2023
@mykola-mokhnach mykola-mokhnach deleted the cleanup_schedule branch November 17, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants