Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: argilla-io/argilla
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.13.2
Choose a base ref
...
head repository: argilla-io/argilla
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.13.3
Choose a head ref
  • 3 commits
  • 9 files changed
  • 3 contributors

Commits on Jul 26, 2023

  1. docs: Resolve typos, missing import (#3443)

    Closes #3429
    
    Hello!
    
    # Description
    
    Resolves typos and a missing import as described by #3429
    
    **Type of change**
    
    - [x] Documentation update
    
    **How Has This Been Tested**
    
    I ran the snippet that I modified - it worked.
    
    **Checklist**
    
    - [x] I added relevant documentation
    - [ ] follows the style guidelines of this project
    - [x] I did a self-review of my code
    - [ ] I made corresponding changes to the documentation
    - [ ] My changes generate no new warnings
    - [ ] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
    (see text above)
    - [ ] I have added relevant notes to the CHANGELOG.md file (See
    https://keepachangelog.com/)
    
    ---
    
    - Tom Aarsen
    tomaarsen authored Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4d04835 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Configuration menu
    Copy the full SHA
    2d0029a View commit details
    Browse the repository at this point in the history
  2. fix: import errors when importing from argilla.feedback (#3471)

    # Description
    
    This PRs fixes the `ModuleNotFoundError` and `ImportError` that occurred
    when trying to import something from `argilla.feedback` module.
    
    The first error was caused because in #3336 the telemetry was included
    in the `ArgillaTrainer`, but in the `argilla.utils.telemetry` module
    some optional dependencies used by the server were being imported.
    
    The second one was caused because the module in which
    `HuggingFaceDatasetMixin` (and from which `FeedbackDataset` is
    inheriting) class lives was importing classes from the
    `argilla.client.feedback.config` module, which was importing `pyyaml` in
    its root causing the `ImportError`.
    
    Closes #3468 
    
    **Type of change**
    
    - [x] Bug fix (non-breaking change which fixes an issue)
    
    **How Has This Been Tested**
    
    I've created a wheel of this branch, installed in a new virtual
    environment and I was able to import something `argilla.feedback` module
    without errors.
    
    **Checklist**
    
    - [ ] I added relevant documentation
    - [x] follows the style guidelines of this project
    - [x] I did a self-review of my code
    - [ ] I made corresponding changes to the documentation
    - [x] My changes generate no new warnings
    - [x] I have added tests that prove my fix is effective or that my
    feature works
    - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
    (see text above)
    - [x] I have added relevant notes to the CHANGELOG.md file (See
    https://keepachangelog.com/)
    
    ---------
    
    Co-authored-by: Francisco Aranda <[email protected]>
    gabrielmbmb and frascuchon authored Jul 27, 2023
    Configuration menu
    Copy the full SHA
    d37ea7e View commit details
    Browse the repository at this point in the history
Loading