feat: add analytics #1188
feat: add analytics #1188
Conversation
🦋 Changeset detectedLatest commit: dd736e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for modest-rosalind-098b67 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for asyncapi-studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
You might need to do a netlify deploy with a dummy G-Tag from your account for verifying and testing purposes. @AayushSaini101 would also have a look and let you know the other changes. |
@DhairyaMajmudar Let's do a testing for this and check whether it is analysing or, we can use deployed application and make some calls on the endpoints to test it thanks : ) |
f919b8d to
3f3dd5e
Compare
|
Here is the netlify deployed demo link https://dummystudio.netlify.app/ I've also mentioned the steps about how to test this URL using Google Tag Manager in the PR description. Other than these I've also created a short demo video, but unfortunately it leaks my Google tag manager ID, If that's okay I can share it to your slack DMs ? |
bfdf6fa to
5ca45fe
Compare
|
@Shurtu-gal @AayushSaini101 just a ping for PR review, Thank you =) |
|
@asyncapi/bounty_team |
sure share the video @DhairyaMajmudar |
Shared 👍🏻 |
Waiting for the @Amzani approval thanks for the demo |
|
@Amzani just a ping for PR review, Thank you : ) |
Amzani
left a comment
There was a problem hiding this comment.
If NEXT_PUBLIC_ANALYTICS_ID is not set, GTM_ID defaults to an empty string (''). It appears that the GoogleTagManager components will still be rendered even if GTM_ID is empty. This might result in an unintended attempt to load Google Tag Manager with an empty ID.
You might want to add a condition to check whether GTM_ID is non-empty before rendering the GoogleTagManager components to avoid this issue. Let me know if you'd like further assistance with this!
Signed-off-by: Dhairya Majmudar <[email protected]>
Signed-off-by: Dhairya Majmudar <[email protected]>
|
@Amzani you may need to need to finalize the list of events which are being tracked as well. |
|
@Shurtu-gal we can go with the implemented events for now, and add any missing one in the future. |
|
@DhairyaMajmudar could you just add a changeset and this would be good to go. @Amzani you might need to register app in google, I don't have access for it. |
Added a changeset, Thank you @Shurtu-gal |
|
|
/rtm |
|
Reverting this PR as the env was not made and added leading to the website breaking. |
This reverts commit ef86b5b.
|
I will be adding the changes back once the requisite env has been added. |
|
😐 |
Yeah it was our fault for not doing the due diligence. I will be adding these changes back once @fmvilas is available though. |
Description
This PR adds Google Tags Manager (GTM) and the utility files to push event data to the GTM datalayer.
Related issue(s)
Fixes #858
PR Testing
To test the PR one need to follow below steps:
GTM-XXXXXXX.envfile intoapps/studioand taste the below env variable thiercc: @AayushSaini101