feat: Support Placeholders with ModelStep #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivlaks
previously approved these changes
Oct 27, 2021
| if isinstance(model, FrameworkModel): | ||
| parameters = model_config(model=model, instance_type=instance_type, role=model.role, image_uri=model.image_uri) | ||
| model_parameters = model_config(model=model, instance_type=instance_type, role=model.role, image_uri=model.image_uri) |
There was a problem hiding this comment.
nit: didn't really have an objection to this parameter name since they do ultimately resolve to Parameters and you're calling the model_config method to assign it.
There was a problem hiding this comment.
This was renamed to avoid confusion with the input parameters provided in the args
jormello
reviewed
Oct 27, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
shivlaks
approved these changes
Oct 27, 2021
jormello
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to define Model parameters dynamically using placeholders
Fixes #117
Why is the change necessary?
Currently, it is not possible to use placeholders for Sagemaker Model parameters. The properties cannot be defined dynamically, as they need to be defined in the Model which does not accept placeholders.
This change makes it possible to use placeholders for Model properties by using the parameters field that are passed down from the ModelStep.
Solution
Use the
parametersfield that is compatible with placeholders to define ModelStep properties.Merge the parameters that were generated from the Model with the input parameters:
Testing
Added unit and integ tests
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
Documentation
Title and description
Fixes #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.