Fix duplicate printing of thread info when debug is enabled #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepapadim
approved these changes
Feb 1, 2024
| @@ -298,7 +298,7 @@ private int submitSequential(final TaskMetaData meta) { | |||
| final int task; | |||
| debugInfo(meta); | |||
|
|
|||
| if (meta.isThreadInfoEnabled()) { | |||
| if (meta.isThreadInfoEnabled() && !meta.isDebug()) { | |||
There was a problem hiding this comment.
Suggested change
| if (meta.isThreadInfoEnabled() && !meta.isDebug()) { | |
| if (meta.isThreadInfoEnabled() || meta.isDebug()) { |
There was a problem hiding this comment.
it shouldnt be like this? To be part of the --debug by default?
There was a problem hiding this comment.
If this changes is accepted, then we need to remove the printing from the debugger (which has a separate printing method).
There was a problem hiding this comment.
I think is better to keep it in one place.
There was a problem hiding this comment.
Yes, let's do that. @mairooni , can you remove the condition for the isolated debug mode?
There was a problem hiding this comment.
I removed the printing of thread info from the printing of debug. Now the thread info is printed only when --threadInfo is set to true, like the PTX and SPIR-V backends.
|
thanks @mairooni |
jjfumero
added a commit
that referenced
this pull request
Feb 29, 2024
Improvements ~~~~~~~~~~~~~~~~~~ - `#323 <https://github.com/beehive-lab/TornadoVM/pull/323>`_: Set Accelerator Memory Limit per Execution Plan at the API level - `#328 <https://github.com/beehive-lab/TornadoVM/pull/328>`_: Javadoc API to run with concurrent devices and memory limits - `#340 <https://github.com/beehive-lab/TornadoVM/pull/340>`_: New API calls to enable ``threadInfo`` and ``printKernel`` from the Execution Plan API. - `#334 <https://github.com/beehive-lab/TornadoVM/pull/334>`_: Dynamically enable/disable profiler after first run Compatibility ~~~~~~~~~~~~~~~~~~ - `#337 <https://github.com/beehive-lab/TornadoVM/pull/337>`_ : Initial support for Graal and JDK 21.0.2 Bug Fixes ~~~~~~~~~~~~~~~~~~ - `#322 <https://github.com/beehive-lab/TornadoVM/pull/322>`_: Fix duplicate thread-info debug message when the debug option is also enabled. - `#325 <https://github.com/beehive-lab/TornadoVM/pull/325>`_: Set/Get accesses for the ``MatrixVectorFloat4`` type fixed - `#326 <https://github.com/beehive-lab/TornadoVM/pull/326>`_: Fix installation script for running with Python >= 3.12 - `#327 <https://github.com/beehive-lab/TornadoVM/pull/327>`_: Fix Memory Limits for all supported Panama off-heap types. - `#329 <https://github.com/beehive-lab/TornadoVM/pull/329>`_: Fix timers for the dynamic reconfiguration policies - `#330 <https://github.com/beehive-lab/TornadoVM/pull/330>`_: Fix the profiler logs when silent mode is enabled - `#332 <https://github.com/beehive-lab/TornadoVM/pull/332>`_: Fix Batch processing when having multiple task-graphs in a single execution plan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the duplicate printing of thread information. When both the flags for debugging (
--debug) and thread info (--threadInfo) were enabled, the thread information was printed twice. In this PR, the thread information is printed only if the debug flag is not also enabled.Backend/s tested
Mark the backends affected by this PR.
OS tested
Mark the OS where this PR is tested.
Did you check on FPGAs?
If it is applicable, check your changes on FPGAs.