Skip to content

Update computed_states example to use children macro #18290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

krunchington
Copy link
Contributor

Objective

Contributes to #18238
Updates the computed_states, example to use the children! macro. Note that this example requires --features bevy_dev_tools to run

Solution

Updates examples to use the Improved Spawning API merged in #17521

Testing

  • Did you test these changes? If so, how?
    • Opened the examples before and after and verified the same behavior was observed. I did this on Ubuntu 24.04.2 LTS using --features wayland.
  • Are there any parts that need more testing?
    • Other OS's and features can't hurt, but this is such a small change it shouldn't be a problem.
  • How can other people (reviewers) test your changes? Is there anything specific they need to know?
    • Run the examples yourself with and without these changes.
  • If relevant, what platforms did you test these changes on, and are there any important ones you can't test?
    • see above

Showcase

n/a

Migration Guide

n/a

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Mar 13, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Mar 13, 2025
Merged via the queue into bevyengine:main with commit 2c22bc1 Mar 13, 2025
35 checks passed
@krunchington krunchington deleted the issue/18238-continued branch March 13, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants