This repository was archived by the owner on Jun 20, 2023. It is now read-only.
EOL-14954-offline-onboarding-shows-popup-for-risk-calculation #5156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flxschmidt
approved these changes
Apr 12, 2023
| @@ -923,6 +923,7 @@ class HomeTableViewController: UITableViewController, NavigationBarOpacityDelega | |||
| private func showBackgroundFetchAlertIfNeeded(completion: @escaping () -> Void = {}) { | |||
| if CWAHibernationProvider.shared.isHibernationState { | |||
| completion() | |||
| return | |||
There was a problem hiding this comment.
As we need a return here, I would prefer a guard. That's the same result, but makes the code more clearly. :)
…popup-for-risk-calculation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missing return from the hibernation check makes the alert shows in some cases
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14954
Screenshots
RPReplay_Final1683108662.MP4