This repository was archived by the owner on Jun 20, 2023. It is now read-only.
Fix/15131 Quick actions are not reduced correctly in hibernation state #5169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
src/xcode/ENA/ENA/Source/AppDelegate & Globals/AppDelegate+QuickActions.swift
Outdated
Show resolved
Hide resolved
naveeddotio
reviewed
May 3, 2023
| @@ -108,7 +108,13 @@ final class HealthCertificateCoordinator { | |||
| private var validationCoordinator: HealthCertificateValidationCoordinator? | |||
|
|
|||
| private var infoScreenShown: Bool { | |||
| get { store.healthCertificateInfoScreenShown } | |||
| get { | |||
There was a problem hiding this comment.
what's the usage of this change?
There was a problem hiding this comment.
Good question!
The usage is, that the info screen has texts like "Add certificates" and that would be not a use case in hibernation, because we only show certificates. Thatswhy I change the getter for hibernation and skip the info screen at this point.
There was a problem hiding this comment.
I guess that's a first (and maybe the only) move reg. corona-warn-app/cwa-documentation#950?
…ckActions.swift Co-authored-by: Puneet Mahali <[email protected]>
naveeddotio
approved these changes
May 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The quick actions "QR-Codes sannen" & "Check-ins anzeigen" should not be shown in hibernation state.
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-15131
Screenshots