Skip to content

Rename Feature to Attribute #3499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Conversation

srawlins
Copy link
Member

Since forever we've had this thingy called Features, which include annotations, and some other attributes of elements, like whether a field is read-only, etc. But then along came language features. To improve our jive with the language spec, we need to rename Feature to Attribute.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@srawlins srawlins requested a review from keertip September 20, 2023 17:57
Copy link
Collaborator

@keertip keertip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@srawlins srawlins merged commit a3cfdc4 into dart-lang:main Sep 20, 2023
@srawlins srawlins deleted the rename-feature branch September 20, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants