Fix substitution into record projection by type #1012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1009 The `subst`/`shift`/`subExpressions` functions did not correctly reflect the recent change to support projection by type
|
Change looks good to fix the proximal problem, but I'm still concerned by how the testsuite wasn't able to catch it. I guess the test code isn't using the same code-path as the production code somehow. |
|
@quasicomputational: It's because the normalization test suite wasn't type-checking the code. The (slower) type-checking code uses the The absence of type-checking is the difference between the test code path and the production code path. The reason the test code is not type-checking is because of the unit tests (which are not well-typed since they are full of unbound variables). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1009
The
subst/shift/subExpressionsfunctions did not correctlyreflect the recent change to support projection by type