[dhall format] Prefer unquoted URLs #1235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates `dhall format` to prefer unquoted URLs. I included the test cases described in dhall-lang#1109, but along the way I discovered a standard bug so I have opened dhall-lang/dhall-lang#704 to fix it. This change depends on that upstream fix. Fixes dhall-lang#1109.
This was referenced Aug 13, 2019
Gabriella439
approved these changes
Aug 20, 2019
|
@philandstuff: Feel free to skip newly-added test cases that we haven't addressed yet |
940d4f5 to
2c0920d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
dhall formatto prefer unquoted URLs.I included the test cases described in #1109, but along the way I
discovered a standard bug so I have opened dhall-lang/dhall-lang#704 to
fix it. This change depends on that upstream fix.
Fixes #1109.