Add --no-cache flag #1290
Merged
Add --no-cache flag #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabled, we handle protected imports as if the semantic cache was
empty:
* Protected imports are resolved again, downloaded or read from
the filesystem as necessary.
* Protected imports are β-normalized, not αβ-normalized.
* Protected imports are checked against their SHA256 hashes,
failing to resolve if they don't match.
Context:
#1275 (comment)
sjakobi
commented
Sep 7, 2019
| mCached <- | ||
| case _semanticCacheMode of | ||
| UseSemanticCache -> liftIO $ fetchFromSemanticCache semanticHash | ||
| IgnoreSemanticCache -> pure Nothing | ||
|
|
||
| case mCached of | ||
| Just bytesStrict -> do |
There was a problem hiding this comment.
A bit further below we also writeToSemanticCache – IMHO it's not necessary to disable this, but we could.
Gabriella439
reviewed
Sep 8, 2019
… as suggested by @Gabriel439.
Gabriella439
approved these changes
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabled, we handle protected imports as if the semantic cache was
empty:
the filesystem as necessary.
failing to resolve if they don't match.
Context:
#1275 (comment)