Add --censor switch for disabling source code display
#1312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #1294 This currently only affects parse errors, but can later be extended to type errors, too
sjakobi
approved these changes
Sep 13, 2019
dhall/src/Dhall/Util.hs
Outdated
|
|
||
| -- | Convenient utility for retrieving an expression | ||
| getExpression | ||
| :: Bool |
There was a problem hiding this comment.
A dedicated CensorMode or similar would probably be more readable.
dhall/src/Dhall/Util.hs
Outdated
| getExpression | ||
| :: Bool | ||
| -- ^ Censor the source code? | ||
| -> Maybe FilePath |
There was a problem hiding this comment.
Nothing arguments also smell a bit like boolean blindness to me. IMHO the straightforward fix would be to have both getExpressionFromFile and getExpressionFromStdin, but it's not important to me.
... as requested by @sjakobi * Replace `Bool` with `Censor` * Replace `Maybe FilePath` with `Input`
|
Many thanks for the much nicer types! :) |
|
@sjakobi: You're welcome! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1294
This currently only affects parse errors, but can later be extended
to type errors, too