Fix parsing of variables with keyword prefixes #1584
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1583 Note that one prefix is not yet supported: `missing`, since fixing that is not easy for the current parsing implementation (as far as I can tell).
sjakobi
approved these changes
Dec 2, 2019
... as suggested by @sjakobi I'm not upstreaming this into the standard test suite yet because the current parser cannot handle `missing`, which would be necessary to generate the corresponding CBOR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1583
Note that one prefix is not yet supported:
missing, since fixing that isnot easy for the current parsing implementation (as far as I can tell).