Skip to content

Fix parsing of the Some keyword #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2018
Merged

Fix parsing of the Some keyword #658

merged 2 commits into from
Oct 26, 2018

Conversation

Gabriella439
Copy link
Collaborator

Fixes #655

The standard grammar specifies that Some must be followed by
non-empty whitespace, so that an identifier like SomeCons is not
parsed as Some Cons.

@Gabriella439
Fix parsing of the Some keyword
57acb36 
Fixes #655

The standard grammar specifies that `Some` must be followed by
non-empty whitespace, so that an identifier like `SomeCons` is not
parsed as `Some Cons`.
@Gabriella439 Gabriella439 mentioned this pull request Oct 25, 2018
Closed
f-f
f-f reviewed Oct 25, 2018
View reviewed changes
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also None have this fix?

@Gabriella439
Copy link
Collaborator Author

@f-f: None already works correctly (both in the grammar and in the Haskell implementation)

@Gabriella439 Gabriella439 merged commit 84c99bf into master Oct 26, 2018
@Gabriella439 Gabriella439 deleted the gabriel/SomeCons branch October 26, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-f f-f f-f left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gabriella439 @f-f