Skip to content

FEATURE: include tag sidebars, migrate to objects setting #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2024

Conversation

awesomerobot
Copy link
Member

@awesomerobot awesomerobot commented May 24, 2024

This incorporates the tag sidebar functionality from: https://github.com/awesomerobot/discourse-tag-sidebars/ so that theme component can be deprecated.

Now this component will be able to show topic-populated sidebars for categories and tags.

This also:

  • migrates to the objects setting type, which allows for easier category and tag selection using the respective setting types
  • allows a single setting value to assign a topic to multiple categories and tags
  • adds an acceptance test for tag sidebars
  • adds a migration test
  • renames the component to "Discourse Topic List Sidebars"

image

When a tag is assigned, it will take precedence over a category. If the same category or tag is used in multiple settings, the most recently created setting will apply.

Because this migrates a category slug to a category using getCategoryIdByName there may be some edge cases when a category slug doesn't align with the expected category name.

@awesomerobot awesomerobot merged commit e63c903 into main May 29, 2024
@awesomerobot awesomerobot deleted the feature-tags branch May 29, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants