Skip to content

Conversation

tshenry
Copy link
Member

@tshenry tshenry commented Jul 21, 2020

This will bring the behavior of the Submit From Preview mobile theme component into core.

Before
before

After
after

Behavior Notes

  • A bottom-border has been added to the preview to effectively create a "button footer". I think this makes the buttons much more readable.
  • Submitting a post that does not meet title, body, etc requirements will immediately close the preview, exposing the relevant requirement tips that are normally displayed in the composer.
  • While the preview is open, the auto-save checkmark may display next to the submit button as it would when the preview is not displayed
  • The cancel/trash draft icons are suppressed while the preview is open. I don't think we need to expose every button option in the preview.

@tshenry tshenry merged commit 723d7e3 into master Jul 22, 2020
@tshenry tshenry deleted the submit-from-mobile-composer branch July 22, 2020 16:17
@discoursebot
Copy link

This pull request has been mentioned on Discourse Meta. There might be relevant details there:

https://meta.discourse.org/t/submit-from-preview-mobile/157881/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants