Skip to content

NEW: Added component question type #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2020
Merged

NEW: Added component question type #109

merged 2 commits into from
Sep 16, 2020

Conversation

venarius
Copy link

Hey, again 👋

This is also something we need: A question type where we can show our own components (e.g. contact forms). This PR adds such component and I also added a seperate example for it where you can test it out.

It currently adds two props to the question model:

  • component -> Here the user needs to supply their component.
  • validateComponent -> If set to true "vue-flow-form" will call the isValid() method on the given component to check if its valid before it continues.

If you have any questions or feedback, just let me know 😀

@phre1
Copy link
Contributor

phre1 commented Sep 16, 2020

This is a really interesting suggestion - although we feel this should be tested and refined a bit more. If we decide to support this, we'd need to create and document some sort of plugin API that custom components would need to follow to make them fully integrated with the rest of Flow Form. We'll pull this request into an experimental branch so we can further test it out and possibly improve it.

@phre1 phre1 changed the base branch from master to experimental/custom-question-type September 16, 2020 17:37
@phre1 phre1 merged commit 5af1ef3 into ditdot-dev:experimental/custom-question-type Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants