Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

osmodel.mak: Mention tools + dlang.org repos in the update reminder #1780

Closed

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Mar 2, 2017

  • The osmodel.mak files weren't in sync
  • Since a couple of weeks the tools and dlang.org repo use the same file

Btw this manual sync seems very error-prone and labour-intensive.
Why can't we do an include $(DMD_DIR)/src/osmodel.mak?

@wilzbach wilzbach force-pushed the os-model-mention-tools-and-dlang-org branch 2 times, most recently from 5a0ce37 to 02627c3 Compare March 2, 2017 16:43
@wilzbach wilzbach force-pushed the os-model-mention-tools-and-dlang-org branch from 02627c3 to 04b4770 Compare March 2, 2017 16:44
@wilzbach
Copy link
Member Author

wilzbach commented Mar 2, 2017

Why can't we do an include $(DMD_DIR)/src/osmodel.mak?

So I change the PR to do this as we require the dmd repo to build anyways and it's hard to get an outdated file, if there's only one ;-)

Btw additionally we could even let the Makefile clone dmd automatically if it doesn't exists, but that's not directly relevant for this PR.

edit: FYI we already require other things directly from the dmd repo, like the VERSION file.

@MartinNowak
Copy link
Member

Btw additionally we could even let the Makefile clone dmd automatically if it doesn't exists, but that's not directly relevant for this PR.

Please no, it's already a nightmare to work with the dlang.org Makefile in builds scripts. Let's not turn more Makefiles into their own build scripts.

@MartinNowak
Copy link
Member

We have been over this, see #698 and dlang/phobos#1806.
Having separate repos for all components turned be a pain in many places, but a single (or meta) repo would have it's own downsides (though likely less).
If we can figure out a good way to store common makefiles and script components somewhat, that'd sound reasonable. We also still want to move the dlangci repo to dlang/ci.

Maybe we'd rather add a dlang/build or dlang/common repo that all components can rely on.

@wilzbach
Copy link
Member Author

wilzbach commented May 5, 2017

Maybe we'd rather add a dlang/build or dlang/common repo that all components can rely on.

Well, the idea was to use tools as common repo, because it avoids to create yet another repo & tools is already required at Phobos for some targets (e.g. style).

Anyway this takes much more effort than initially thought, so I am closing this.
If anyone wants to pick this up & push for a less redundant build system, please do so!

@wilzbach wilzbach closed this May 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants